Thank you for making this happen Adi! Sorry for the slow feedback, but here are 
a few comments. None seem blocking to me; it's totally xfine to proceed per the 
schedule.

On Tue, May 24, 2022, at 4:56 AM, Adi Roiban wrote:
> We still need to see how to put the GitHub twisted/twisted repo in a
> protected mode during the migration.
>
> One option to temporarily rename the main branch as "DONT-CREATE-A-PR-YET"
> and have a new PR template that will explain that people should wait 1
> day for the migration to be finalized.
>
> Suggestions are welcomed for how to do the migration.
>
> Making the repo private is not an option.
> The followers/starts will be lost, and repo owners can still create PRs.

Perhaps set interaction limits for the duration of the migration as well? 
https://github.com/twisted/twisted/settings/interaction_limits

> ----------------
>
> There is a list of issues with ID from 1 to 1732
>
> So Trac ID 1 was migrated as
> https://github.com/twisted/twisted-trac-migration/issues/11323
>
> Trac tickets with IDs 1733 or greater have a direct mapping.
> So Trac with ID 1733 is
> https://github.com/twisted/twisted-trac-migration/issues/1733

Could these go in a repo like https://github.com/twisted/trac so that they can 
be referenced under the original numbers as "trac#1"? I see that syntax used in 
some of the migrated tickets.

> ----------
>
> The migration will take about 1 day.
> This is slow as GitHub API is throttling the requests.
>
> The high-level plan targeting  4-5 June for going live:
>
> * Gather feedback in the next days and implement the required changes.
> * Next Monday, 30rd of May, re-run a full import for testing
> * By next Wednesday, the 1st of June, the testing import should be ready
> * Review the full migration and see if this is ready for going live.
> * Wait for feedback until Friday 3 of June.
> * If there are no complaints, the final / PROD migration will be
> triggered over the 4-5 June weekend.
>
>
> -----------------
>
>  Below are some examples.
>
> # Reopened, enhancement, link to another ticket
> https://github.com/twisted/twisted-trac-migration/issues/3621
>
> # Reopened, attachment
> https://github.com/twisted/twisted-trac-migration/issues/4258
>
> # a lot of changes and attachments
> https://github.com/twisted/twisted-trac-migration/issues/4536

Could the branch name here be made a link? It corresponds to 
https://github.com/twisted/twisted/tree/password-comparison-4536-2

Not a big deal though.

> # Enhancement, second comment replies to different ticket
> https://github.com/twisted/twisted-trac-migration/issues/6887
>
> # Reopened -> new
> https://github.com/twisted/twisted-trac-migration/issues/9300
>
> # Reopened -> closed, milestone, code example
> https://github.com/twisted/twisted-trac-migration/issues/9335
>
> # With assigned team member, enhancement, new milestone, fixed
> https://github.com/twisted/twisted-trac-migration/issues/10027

The rest of these look great! Looking forward to much simpler infra.

Thanks again,
Tom
_______________________________________________
Twisted mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/twisted.python.org/
Message archived at 
https://mail.python.org/archives/list/[email protected]/message/A6CGJCP6QA2GC7DFIXAVELWPFOLLWKOW/
Code of Conduct: https://twisted.org/conduct

Reply via email to