Thanks, David! Please keep us posted if you have any issues when improving those type hints in Synapse. These definitely look like ugly workarounds for previously incorrect hints in Twisted though, I imagine this will feel better to work with once it lands.
-g > On Mar 21, 2023, at 11:23 AM, David Robertson via Twisted > <twisted@python.org> wrote: > > All type hints gratefully received! > > On 16/03/2023 22:45, Glyph wrote: >> If you've got some application code that you would like to type-check >> against these to see if they spot any bugs for you, that would be great, but >> if we I could get these approved, this type of comprehensive type-safety >> upgrade would make a nice tentpole for our first 2023 release. > > I have just kicked off a run of Synapse's CI against the Deferred branch. It > is somewhat unhappy [1], but eyeballing the error messages I can believe > those are false positives that can be fixed by better annotations in Synapse. > In other words: no red flags that I can see. > > I haven't tried the other branch: as far as I can see (well, grep), we don't > use FilePath ourselves. > > [1]: > https://github.com/matrix-org/synapse/actions/runs/4482279504/jobs/7880109503 > > David R > > -- > > > Copyright © 2023 Element - All rights reserved. The Element name, logo and > device are registered trademarks of New Vector Ltd. Registered number: > 10873661. Registered in England and Wales. Registered address: 10 Queen > Street Place, London, United Kingdom, EC4R 1AG. > > This message is intended for the addressee only and may contain private and > confidential information or material which may be privileged. If this message > has come to you in error please delete it immediately and do not copy it or > show it to any other person. > _______________________________________________ > Twisted mailing list -- twisted@python.org > To unsubscribe send an email to twisted-le...@python.org > https://mail.python.org/mailman3/lists/twisted.python.org/ > Message archived at > https://mail.python.org/archives/list/twisted@python.org/message/737KSF2Y6P2CXXKKQM2FFDYNIS4SFI2X/ > Code of Conduct: https://twisted.org/conduct _______________________________________________ Twisted mailing list -- twisted@python.org To unsubscribe send an email to twisted-le...@python.org https://mail.python.org/mailman3/lists/twisted.python.org/ Message archived at https://mail.python.org/archives/list/twisted@python.org/message/HWVDY76X726SCE5WL3Z5JKNUKGC7EEKV/ Code of Conduct: https://twisted.org/conduct
