Thanks, Renoir. That's perhaps a rather more detailed reply than I was expecting ;-)
Yes, the @ sign shouldn't appear in a URL - I just put it there for testing, but have now made the URL nicer and dropped any camel casing - see http://www.fredriley.org.uk/callhull/home.html The empty class attributes came from code generated by Jetstrap, which I used to start the design off, and to see what Bootstrap code comes from particular elements (eg hero units, wells, etc). If I'd had to build Bootstrap code from scratch I wouldn't have done - my whole aim in using Bootstrap is to save development time, not extend it, and for rapid prototyping. That said, I want to be able to understand what BS code does and why - I hate it when I don't understand generated code. Similarly, the extraneous <br> tags came from Jetstrap, and I'm slowly editing those out where they're not needed. Thanks for the links, I'll have a look at them when I get a bit of time. Cheers Fred On Friday, November 30, 2012 1:56:24 AM UTC, Renoir Boulanger wrote: > > Pardon my double post. > > I only read the digest, and forgot to send through the Google Groups to > give followup. > > Here is my answer: > > ---------------------- >8 --------------------------------- > > To answer Fred Riley, about "Dropdown menu: top left > caret<http://groups.google.com/group/twitter-bootstrap/t/3e4603e1a873aac> > ": > > Here is my first review of your code. > > It is not really related to Twitter Bootstrap itself, but since I happen > sometimes to sniff "new to web development" people, I thought I could guide > you a bit. > > My observations: > > *File name served on the web* > Please, do not use @ character in a file name, characters such as @, > (spaces), (comas ","), &, and %; accented characters are not recommended > either for any file name that are exposed to the http protocol. > > Not that it cannot work, it is just that it is a convention and mostly do > not mixup transforming your file from "my beautiful file name with a % in > it.css" to > "my%20beautiful%20file%20name%20with%20a%20%25%20and%20a%20%26%20in%20it.css". > > This is called url encoding. And can be causing problem to you in the > future. > > Same could apply for CamelCasing, if you happen to use Windows as a web > server, it doesnt' take into account camel CASE and on a Linux server, you > may not find the file either. > > Good to read regarding URL: > > - http://warpspire.com/posts/url-design/ > > > > *Unused attributes* > I saw you put class="" in some cases, it is always better to not leave > those kind of attributes. Nothing harmful though :) > > > > *Use of <br>* > The BR in your li could be replaced with a , but think, you could > have done a > > #leftnav .sidebar-nav .nav-header { margin-bottom: 30px; } > > But beware, > > - if you always want to have space after the .nav-header, you should > ommit the #leftNav, because it binds to the document id > - you forgot to add the .nav classname along with the sidebar-nav. > This is because you may want to affect all "nav" type of blocks. > > Good read about CSS structure > > - http://www.slideshare.net/stubbornella/object-oriented-css - Nicolle > Sullivan is one of the prominent author describing css architecture > - http://www.slideshare.net/nataliedowne/css-systems-presentation - > Nathalie Downe also wrote a very concise presentation on the subject > - if you use W3Schools... please stop right now! > http://w3fools.com/ > > * > * > *Last* > Also, I am currently creating a "best practices" site that is there to > give advice to people who wants to learn to do web development. > > http://htmlcsstherightway.org/ > > It is a "fork me" style of site and even though the site is dormant for > now (I have tons of content to write, but not the time) I have put some > good pointers. > > > Hope it helped > > > > *Renoir B.* > ~ >
