Hi Gerrit,

I am very sorry! I only checked the internal usage inside the module. If
you still rely on those functions, they are still present in typhon.physics
(typhon/physics/em.py).

But I definitely support your point on unit testing.

/Lukas

2016-10-07 15:51 GMT+02:00 Gerrit Holl <g.h...@reading.ac.uk>:

> On 6 October 2016 at 13:35, artswebserv...@gmail.com
> <artswebserv...@gmail.com> wrote:
> > * typhon/physics/units/em.py:
> >
> > Removed conversion functions as they are not needed.
>
> Granted that they are not needed.  There were still in use, though,
> for example, on three occasions in tovs.py, in code predating me
> starting to use pint.
>
> I suppose this shows that systematic and comprehensive unit testing
> would be a good thing.
>
> Gerrit.
> _______________________________________________
> typhon.mi mailing list
> typhon.mi@lists.uni-hamburg.de
> https://mailman.rrz.uni-hamburg.de/mailman/listinfo/typhon.mi
>
_______________________________________________
typhon.mi mailing list
typhon.mi@lists.uni-hamburg.de
https://mailman.rrz.uni-hamburg.de/mailman/listinfo/typhon.mi

Reply via email to