Gary Shewan <[EMAIL PROTECTED]> writes:
> On 14 Apr 2006, at 15:59, Piers Cawley wrote:
>>> I don't understand what you're getting at here ... at all.  And I've
>>> tried.
>>
>> Bah! You obviously haven't tried hard enough!
>
> True
>
>> I want to stop every theme and its brother *having* to override
>> default.rhtml. It's a 'nice' feature, but we're definitely cracking
>> nuts with sledgehammers if we end up overriding default.rhtml just
>> because we want to change a stylesheet.

[...]

> The dawn of a new day brings clarity :)

Mmm... clarity... I like clarity.

> I can see the benefit of that, definitely.  But is it not _almost_
> like doing the same thing as overriding default.rhtml ... 'cept in
> separate files?  For instance, let's say I need to place my own meta
> tags, a custom div and a custom footer.  At the moment that all goes
> in the themes default.rhtml.  So in the future I'd have to put the
> meta tags in 'common/header', and I want the custom div before the
> content so I'd normally place that just before the content is called
> in default.rhtml ... would I place that at the top of 'content'?
> (There would be a 'common/content'?)  The custom work for the footer
> would then go into 'common/footer' - obviously :) Now that's not
> about CSS.  I haven't even styled any changes yet. But is that
> right?

Well, yes, and no. The benefit of overriding your footer in
common/_footer.rhtml[1] and your header stuff in common/_sidebar.rhtml
etc is that you don't have to copy quite so much crap (that might
change, but we hope not) just to make your changes. And we'll probably
arrange things so that the default versions will default to include
theme/_extra_headers.html and so, assuming you're not making a major
structural change, you get to write a partial which *only* has stuff
specific to your theme with, with no boiler plate. The aim of the game
is to apply the Hollywood Principle[2] to themes. It works well for
the rest of Rails, so we should be able to make it work for themes as
well. 

>>> I'm lost.
>>>
>>> Is it just me?  Could be ;)
>>>
>>> I readily agree that something needs to be firmed out though because
>>> I'd put money on the fact that nearly every theme in the contest
>>> would be broken in trunk now.
>>
>> Well, if it uses sidebars, it's broken. And if it wants to use at
>> least one of the plugins (can't remember which one) that needs a
>> particular javascript included in the header, it's doubly broken.
>>
>
> So yeah ... pretty much every one.  I smell a new contest after the  
> release of 4.0

Speaking as someone with the graphic design sense of a teeny tiny
kitten, I'd quite like the chance to win a Macbook too. And if there
*is* another competition, can we please try and avoid bitterness this
time? 


1. Partials have a leading _, it's a Rails thing, I'm not entirely
   sure I understand why.

2. Don't call us, we'll call you

-- 
Piers Cawley <[EMAIL PROTECTED]>
http://www.bofh.org.uk/
_______________________________________________
Typo-list mailing list
Typo-list@rubyforge.org
http://rubyforge.org/mailman/listinfo/typo-list

Reply via email to