"Scott Laird" <[EMAIL PROTECTED]> writes:

> I think the Great Typo Memory Leak of 2006 has been fixed:
>
>
> http://scottstuff.net/blog/articles/2006/07/08/ding-dong-the-memory-leak-in-typo-is-dead
>
> It was an interaction between the action cache and all of the other filters
> that we're using--when the action cache's before_filter found a cache hit,
> it cancels the rest of the filter chain and returns the cached results to
> the user.  Unfortunately, if any of the other filters are saving data in
> their before_filter and planning on dropping it in their after_filter, then
> they're going to cause a memory leak, because the after_filter will never be
> called.

Hmm... it's a shame you can't have 'ensure' filters in rails isn't it?

> The fix is to straighen out the filter order.  I moved the cache's filters
> to the very outside, and that gave us a big speed boost, as well as fixing
> the memory leak.  Longer-term, we need to audit our filters, because they're
> getting too complex.  But for now, I think we're okay.

D'oh.

-- 
Piers Cawley <[EMAIL PROTECTED]>
http://www.bofh.org.uk/
_______________________________________________
Typo-list mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/typo-list

Reply via email to