Never mind - sorry for the noise - make option *-n* got added into the mix looking at issues!

On 2026-10-30 13:27, Brian Inglis wrote:
When running `make check` ZDS sub-`make` TZS_NEW rule fails as at bottom:
```
# dummy.zd is not a real file; it is mentioned here only so that the
# top-level 'make' does not have a syntax error.
ZDS = dummy.zd
# Rule used only by submakes invoked by the $(TZS_NEW) rule.
# It is separate so that GNU 'make -j' can run instances in parallel.

$(ZDS): zdump
         ./zdump -i $(TZS_CUTOFF_FLAG) "$$PWD/$(@:.zd=)" >$@

TZS_NEW_DEPS = tzdata.zi zdump zic
$(TZS_NEW): $(TZS_NEW_DEPS)
         rm -fr tzs$(TZS_YEAR).dir
         mkdir tzs$(TZS_YEAR).dir
         $(zic) -d tzs$(TZS_YEAR).dir tzdata.zi
         $(AWK) '/^L/{print "Link\t" $$2 "\t" $$3}' \
            tzdata.zi | LC_ALL=C sort >[email protected]
         x=$$($(AWK) '/^Z/{print "tzs$(TZS_YEAR).dir/" $$2 ".zd"}' \
                 tzdata.zi \
              | LC_ALL=C sort -t . -k 2,2) && \
         set x $$x && \
         shift && \
         ZDS=$$* && \
         $(MAKE) TZS_CUTOFF_FLAG="$(TZS_CUTOFF_FLAG)" \
           ZDS="$$ZDS" $$ZDS && \
         sed 's,^TZ=".*\.dir/,TZ=",' $$ZDS >>[email protected]
         rm -fr tzs$(TZS_YEAR).dir
         mv [email protected] $@
```
possibly because the sub-`make` is run in the top `build` tree dir, where the `make check` is started from, but that appears to be different from where the dir appears to have been created and `make` appears to have been used:
```
$ grep -m2 -C5 'Entering\|Leaving\|No\ssuch\sfile' tzdata-2026f-1.noarch/log/ tzdata-2026f-1-check.log
     shift && \
     ZDS=$* && \
     make TZS_CUTOFF_FLAG="-c 2050" \
       ZDS="$ZDS" $ZDS && \
     sed 's,^TZ=".*\.dir/,TZ=",' $ZDS >>to2050new.tzs.out
make[1]: Entering directory '/usr/src/tzdata/tzdata-2026f-1.noarch/build'
read -r VERSION <version && printf '%s\n' \
       'static char const PKGVERSION[]="(tzcode) ";' \
       "static char const TZVERSION[]=\"$VERSION\";" \
       'static char const REPORT_BUGS_TO[]="[email protected]";' \
       >version.h.out
--
./zdump -i -c 2050 "$PWD/tzs2050.dir/Pacific/Tarawa" 
>tzs2050.dir/Pacific/Tarawa.zd
./zdump -i -c 2050 "$PWD/tzs2050.dir/Pacific/Tongatapu" >tzs2050.dir/Pacific/ Tongatapu.zd
./zdump -i -c 2050 "$PWD/tzs2050.dir/Pacific/Wake" >tzs2050.dir/Pacific/Wake.zd
./zdump -i -c 2050 "$PWD/tzs2050.dir/Pacific/Wallis" 
>tzs2050.dir/Pacific/Wallis.zd
./zdump -i -c 2050 "$PWD/tzs2050.dir/WET" >tzs2050.dir/WET.zd
make[1]: Leaving directory '/usr/src/tzdata/tzdata-2026f-1.noarch/build'
sed: can't read tzs2050.dir/Africa/Abidjan.zd: No such file or directory
sed: can't read tzs2050.dir/Africa/Accra.zd: No such file or directory
sed: can't read tzs2050.dir/Africa/Addis_Ababa.zd: No such file or directory
sed: can't read tzs2050.dir/Africa/Algiers.zd: No such file or directory
sed: can't read tzs2050.dir/Africa/Asmara.zd: No such file or directory
```
although it is difficult to tell because the directory is unconditionally removed after the sub-`make`!

It would be useful if that `sed` was moved to be under the sub-`make` ZDS rule, and/or that following `rm -fr` was removed, or also made conditional on the success of `sed`, and/or depending on some change of the upstream sources, and/ or made a maintainer rule.

It would also be useful if your validations of various distributed sources, like zic warnings, and especially using the network like html, were also made maintainer rules. Many distros have build and check policies that they *MUST* work without any network access, and CIs and build environments may be run in sandboxes or jails isolated from any network. It is also annoying to see three copies of many hundreds of warnings about abbreviations and legacy releases as the build does zoneinfo, posix, and right trees!


--
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retrancher  but when there is no more to cut
                                -- Antoine de Saint-Exupéry

Reply via email to