On 5/8/25 12:32, Sumit Garg wrote:
From: Sumit Garg <sumit.g...@oss.qualcomm.com>

When debug serial port isn't connected, it is at least reported on RB1
that autoboot gets interrupted. It is probably due to random characters
on the UART RX line when disconnected. Lets try to fix this inconsistent
behaviour via enabling AUTOBOOT_KEYED such that the autoboot gets
interrupted only when the <SPACE> key gets pressed.

Honestly I'd much rather fix the bug in the UART driver, maybe it's broken pinctrl?

The older UART driver (for msm8916) had a similar but that Stephen was able to fix with better configuration.

Anyhow, this is a sensible enough workaround if nobody wants to look into GENI...

Reviewed-by: Casey Connolly <casey.conno...@linaro.org>>
Reported-by: Dmitry Baryshkov <dmitry.barysh...@oss.qualcomm.com>
Signed-off-by: Sumit Garg <sumit.g...@oss.qualcomm.com>
---
  configs/qcom_defconfig | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
index 36e2f45d22a..e3dac23f1d0 100644
--- a/configs/qcom_defconfig
+++ b/configs/qcom_defconfig
@@ -15,6 +15,9 @@ CONFIG_FIT_VERBOSE=y
  CONFIG_BOOTSTD_FULL=y
  # CONFIG_BOOTMETH_VBE is not set
  CONFIG_BOOTDELAY=1
+CONFIG_AUTOBOOT_KEYED=y
+CONFIG_AUTOBOOT_PROMPT="Hit <SPACE> key to stop autoboot in %2ds\n"
+CONFIG_AUTOBOOT_STOP_STR=" "
  CONFIG_OF_BOARD_SETUP=y
  CONFIG_USE_PREBOOT=y
  CONFIG_SAVE_PREV_BL_INITRAMFS_START_ADDR=y
--
Casey (she/they)

Reply via email to