On Fri, May 02, 2025 at 03:32:18PM -0600, Tom Rini wrote: > On Wed, Apr 23, 2025 at 01:42:46AM -0700, Sukrut Bellary wrote: > > > This patch series adds the support for > > > > 1. In am33xx SoC[1], enhanced capture (eCAP) supports auxiliary PWM (APWM). > > This series adds the PWM driver support for the APWM feature for eCAP on > > AM33xx. AM335X_ECAP0_IN_PWM0_OUT is used to enable the backlight. > > > > 2. Fix build warning in ti-ehrpwm driver in dev_deb(). > > > > 3. Enable eCAP0 PWM and LCD pin muxing to support splash screen on > > AM335x EVM[2]. > > > > [1] AM335x TRM - https://www.ti.com/lit/ug/spruh73q/spruh73q.pdf > > [2] AM335x EVM - https://www.ti.com/tool/TMDXEVM3358 > > > > per discussion on the earlier patch series, > > https://lore.kernel.org/all/20250319202516.3300444-1-sbell...@baylibre.com/ > > dropping the device tree changes in this series due to OF_UPSTREAM > > conflict. > > As we are dropping the DT patch, started with the new series instead of > > V2. > > > > This series doesn't contain defconfig changes since we don't want to > > enable LCD, splash screen and PWM support by default. > > Enabling splash screen and PWM support in defconfig causes u-boot crash > > on AM335x based beaglebone black. This will be handled in a separate > > patch. > > > > Sukrut Bellary (3): > > pwm: ti: am33xx: Enable Auxiliary PWM using eCAP > > pwm: ti: am33xx: Fix build warnings in dev_dbg() > > board: ti: am335x: Enable eCAP0 PWM and LCD pin muxing > > > > board/ti/am335x/mux.c | 47 +++++++++ > > drivers/pwm/Kconfig | 6 ++ > > drivers/pwm/Makefile | 1 + > > drivers/pwm/pwm-ti-ehrpwm.c | 2 +- > > drivers/pwm/pwm-tiecap.c | 198 ++++++++++++++++++++++++++++++++++++ > > 5 files changed, 253 insertions(+), 1 deletion(-) > > create mode 100644 drivers/pwm/pwm-tiecap.c > > This currently introduces a failure to build on am335x_evm and other > variants of the TI EVM: > arm: + am335x_evm > +(am335x_evm) board/ti/am335x/mux.c: In function 'enable_board_pin_mux': > +(am335x_evm) board/ti/am335x/mux.c:435:50: error: 'lcd_pin_mux' undeclared > (first use in this function); did you mean 'nand_pin_mux'? > +(am335x_evm) 435 | > configure_module_pin_mux(lcd_pin_mux); > +(am335x_evm) | > ^~~~~~~~~~~ > +(am335x_evm) | > nand_pin_mux > +(am335x_evm) board/ti/am335x/mux.c:435:50: note: each undeclared identifier > is reported only once for each function it appears in > +(am335x_evm) board/ti/am335x/mux.c:438:50: error: 'ecap_pin_mux' undeclared > (first use in this function); did you mean 'nand_pin_mux'? > +(am335x_evm) 438 | > configure_module_pin_mux(ecap_pin_mux); > +(am335x_evm) | > ^~~~~~~~~~~~ > +(am335x_evm) make[3]: *** [scripts/Makefile.build:256: > spl/board/ti/am335x/mux.o] Error 1 > +(am335x_evm) make[2]: *** [scripts/Makefile.xpl:548: spl/board/ti/am335x] > Error 2 > +(am335x_evm) make[1]: *** [Makefile:2119: spl/u-boot-spl] Error 2 > +(am335x_evm) make: *** [Makefile:177: sub-make] Error 2 >
Sorry about this. While fixing the checkpatch warning, I overlooked the CONFIG_AM335X_LCD not set case. I will send v2 to fix this. > -- > Tom
