On 6/30/25 02:09, Marek Vasut wrote:
> The stm32-reset-core.h is located in drivers/reset/stm32/ , it has to
> be included using "stm32-reset-core.h" and not <stm32-reset-core.h> ,
> otherwise the build fails. Fix it.
>
> Fixes: 0994a627c278 ("reset: stm32mp25: add stm32mp25 reset driver")
> Signed-off-by: Marek Vasut <marek.va...@mailbox.org>
> ---
> Cc: Gabriel Fernandez <gabriel.fernan...@foss.st.com>
> Cc: Mattijs Korpershoek <mkorpersh...@kernel.org>
> Cc: Patrice Chotard <patrice.chot...@foss.st.com>
> Cc: Patrick Delaunay <patrick.delau...@foss.st.com>
> Cc: Sebastian Reichel <sebastian.reic...@collabora.com>
> Cc: Simon Glass <s...@chromium.org>
> Cc: Tom Rini <tr...@konsulko.com>
> Cc: u-boot@lists.denx.de
> Cc: uboot-st...@st-md-mailman.stormreply.com
> ---
> MAINTAINERS | 1 -
> drivers/reset/stm32/stm32-reset-core.c | 2 +-
> drivers/reset/stm32/stm32-reset-mp1.c | 2 +-
> drivers/reset/stm32/stm32-reset-mp25.c | 2 +-
> drivers/reset/stm32/stm32-reset.c | 2 +-
> 5 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 92119667618..da16816e51c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -730,7 +730,6 @@ F: include/dt-bindings/clock/stm32fx-clock.h
> F: include/dt-bindings/clock/stm32mp*
> F: include/dt-bindings/pinctrl/stm32-pinfunc.h
> F: include/dt-bindings/reset/stm32mp*
> -F: include/stm32-reset-core.h
> F: include/stm32_rcc.h
> F: tools/logos/st.bmp
> F: tools/stm32image.c
> diff --git a/drivers/reset/stm32/stm32-reset-core.c
> b/drivers/reset/stm32/stm32-reset-core.c
> index 7dd92e07e1a..9eeed6536e0 100644
> --- a/drivers/reset/stm32/stm32-reset-core.c
> +++ b/drivers/reset/stm32/stm32-reset-core.c
> @@ -6,7 +6,7 @@
>
> #include <dm.h>
> #include <reset-uclass.h>
> -#include <stm32-reset-core.h>
> +#include "stm32-reset-core.h"
> #include <stm32_rcc.h>
> #include <dm/device_compat.h>
> #include <linux/iopoll.h>
> diff --git a/drivers/reset/stm32/stm32-reset-mp1.c
> b/drivers/reset/stm32/stm32-reset-mp1.c
> index 6863f6e64b7..ce4532561e5 100644
> --- a/drivers/reset/stm32/stm32-reset-mp1.c
> +++ b/drivers/reset/stm32/stm32-reset-mp1.c
> @@ -5,7 +5,7 @@
> */
>
> #include <dm.h>
> -#include <stm32-reset-core.h>
> +#include "stm32-reset-core.h"
>
> /* Reset clear offset for STM32MP RCC */
> #define RCC_CLR_OFFSET 0x4
> diff --git a/drivers/reset/stm32/stm32-reset-mp25.c
> b/drivers/reset/stm32/stm32-reset-mp25.c
> index 91c0336bc58..1cbe5c7f3d5 100644
> --- a/drivers/reset/stm32/stm32-reset-mp25.c
> +++ b/drivers/reset/stm32/stm32-reset-mp25.c
> @@ -5,7 +5,7 @@
> */
>
> #include <dm.h>
> -#include <stm32-reset-core.h>
> +#include "stm32-reset-core.h"
> #include <stm32mp25_rcc.h>
> #include <dt-bindings/reset/st,stm32mp25-rcc.h>
>
> diff --git a/drivers/reset/stm32/stm32-reset.c
> b/drivers/reset/stm32/stm32-reset.c
> index 975f67f712a..918e81e588f 100644
> --- a/drivers/reset/stm32/stm32-reset.c
> +++ b/drivers/reset/stm32/stm32-reset.c
> @@ -5,7 +5,7 @@
> */
>
> #include <dm.h>
> -#include <stm32-reset-core.h>
> +#include "stm32-reset-core.h"
>
> /* Timeout for deassert */
> #define STM32_DEASSERT_TIMEOUT_US 10000
Which version of gcc do you use ? on my side i got no issue with
arm-none-eabi-gcc (Arm GNU Toolchain 14.2.Rel1 (Build arm-14.52)) 14.2.1
20241119
But nevertheless :
Reviewed-by: Patrice Chotard <patrice.chot...@foss.st.com>
Thanks
Patrice
