Thanks Andrew
On Mon, 30 Jun 2025 at 13:23, Andrew Goodbody
<andrew.goodb...@linaro.org> wrote:
>
> The function tpm2_name_to_algorithm is defined as returning an
> enum for the algorithm specified but it also attempts to return
> an error on failure, but that error is not included in the enum.
> Add the error to the enum so that it can be returned.
>
> This issue was reported by Smatch.
>
> Signed-off-by: Andrew Goodbody <andrew.goodb...@linaro.org>
Reviewed-by: Ilias Apalodimas <ilias.apalodi...@linaro.org>
> ---
> include/tpm-v2.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/tpm-v2.h b/include/tpm-v2.h
> index ece422df0c7..f3eb2ef5643 100644
> --- a/include/tpm-v2.h
> +++ b/include/tpm-v2.h
> @@ -20,6 +20,7 @@
> #define __TPM_V2_H
>
> #include <tpm-common.h>
> +#include <linux/errno.h>
>
> struct udevice;
>
> @@ -266,6 +267,7 @@ enum tpm2_return_codes {
> * TPM2 algorithms.
> */
> enum tpm2_algorithms {
> + TPM2_ALG_INVAL = -EINVAL,
> TPM2_ALG_SHA1 = 0x04,
> TPM2_ALG_XOR = 0x0A,
> TPM2_ALG_SHA256 = 0x0B,
>
> --
> 2.39.5
>
