Re: [PATCH 1/3] phy: rockchip: inno-usb2: Add rk3576 config

[Kever Yang]

Hi Andri,

    Thanks for your patch, pls add commit msg for your commit, it 
should not empty.


Thanks,
- Kever
On 2025/7/11 01:31, Andri Yngvason wrote:
Signed-off-by: Andri Yngvason <an...@yngvason.is>
---
  drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 26 +++++++++++++++++++
  1 file changed, 26 insertions(+)

diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c 
b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
index 88b33de1b2a..c38b48d0c71 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
@@ -456,6 +456,28 @@ static const struct rockchip_usb2phy_cfg rk3568_phy_cfgs[] 
= {
        { /* sentinel */ }
  };
  
+static const struct rockchip_usb2phy_cfg rk3576_phy_cfgs[] = {
+       {
+               .reg            = 0x0000,
+               .clkout_ctl     = { 0x0008, 0, 0, 1, 0 },
+               .port_cfgs      = {
+                       [USB2PHY_PORT_OTG] = {
+                               .phy_sus        = { 0x0000, 8, 0, 0, 0x1d1 },
+                       }
+               },
+       },
+       {
+               .reg            = 0x2000,
+               .clkout_ctl     = { 0x2008, 0, 0, 1, 0 },
+               .port_cfgs      = {
+                       [USB2PHY_PORT_OTG] = {
+                               .phy_sus        = { 0x2000, 8, 0, 0, 0x1d1 },
+                       }
+               },
+       },
+       { /* sentinel */ }
+};
+
  static const struct rockchip_usb2phy_cfg rk3588_phy_cfgs[] = {
        {
                .reg            = 0x0000,
@@ -517,6 +539,10 @@ static const struct udevice_id rockchip_usb2phy_ids[] = {
                .compatible = "rockchip,rk3568-usb2phy",
                .data = (ulong)&rk3568_phy_cfgs,
        },
+       {
+               .compatible = "rockchip,rk3576-usb2phy",
+               .data = (ulong)&rk3576_phy_cfgs,
+       },
        {
                .compatible = "rockchip,rk3588-usb2phy",
                .data = (ulong)&rk3588_phy_cfgs,

--
Thanks & Best regards,
  Kever Yang
**************************************************************************************************
杨凯  市场部             Kever Yang      Marketing Department
瑞芯微电子股份有限公司                Rockchip Electronics Co.，Ltd。
地址：福建省福州市铜盘路软件大道89号软件园A区18号楼 (350003)
Addr : No.18 Building，A District，No.89，Fuzhou Software 
Boulevard，Fuzhou，Fujian，PRC