Hi Tom,

On 7/15/25 2:50 PM, Tom Rini wrote:
On Tue, Jul 15, 2025 at 02:23:11PM -0300, Ariel D'Alessandro wrote:
[...]
diff --git a/drivers/fastboot/Kconfig b/drivers/fastboot/Kconfig
index 70207573de2..0cf955ef53d 100644
--- a/drivers/fastboot/Kconfig
+++ b/drivers/fastboot/Kconfig
@@ -91,7 +91,8 @@ config FASTBOOT_USB_DEV
  config FASTBOOT_FLASH
        bool "Enable FASTBOOT FLASH command"
        default y if ARCH_SUNXI || ARCH_ROCKCHIP
-       depends on MMC || (MTD_RAW_NAND && CMD_MTDPARTS)
+       depends on MMC || (MTD_RAW_NAND && CMD_MTDPARTS) || \
+                       (SPI_FLASH || DM_SPI_FLASH)

Why do we need to support the non-DM_SPI_FLASH case? It's legacy and we
shouldn't add new features for it.

You're right, I'll drop that. My mistake as I based the implementation partially on what the sf command does, and of course, that part is legacy.

Thanks! Will submit v2 with that fix.

--
Ariel D'Alessandro
Software Engineer

Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK Registered in England & Wales, no. 5513718

Reply via email to