On 23/07/2025 19:00, Fabio Estevam wrote:
From: Ye Li <ye...@nxp.com>

The 'overhead' variable is uninitialized and actually shall not be used.
Delete it to fix coverity CID 37041718 - Uninitialized scalar variable.

Fixes: 73c40fcb7367 ("spl: Refactor spl_load_info->read to use units of bytes")
Reported-by: Andrew Goodbody <andrew.goodb...@linaro.org>
Signed-off-by: Ye Li <ye...@nxp.com>
Reviewed-by: Peng Fan <peng....@nxp.com>
Signed-off-by: Fabio Estevam <feste...@gmail.com>
---
  common/spl/spl_imx_container.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/spl/spl_imx_container.c b/common/spl/spl_imx_container.c
index b3565efb225a..79d021f81dcd 100644
--- a/common/spl/spl_imx_container.c
+++ b/common/spl/spl_imx_container.c
@@ -31,7 +31,7 @@ static struct boot_img_t *read_auth_image(struct 
spl_image_info *spl_image,
                                          ulong container_offset)
  {
        struct boot_img_t *images;
-       ulong offset, overhead, size;
+       ulong offset, size;
        void *buf, *trampoline;
if (image_index > container->num_images) {
@@ -54,7 +54,7 @@ static struct boot_img_t *read_auth_image(struct 
spl_image_info *spl_image,
        debug("%s: container: %p offset: %lu size: %lu\n", __func__,
              container, offset, size);
- buf = map_sysmem(images[image_index].dst - overhead, images[image_index].size);
+       buf = map_sysmem(images[image_index].dst, images[image_index].size);
        if (IS_ENABLED(CONFIG_SPL_IMX_CONTAINER_USE_TRAMPOLINE) &&
            arch_check_dst_in_secure(buf, size)) {
                trampoline = arch_get_container_trampoline();

Reviewed-by: Andrew Goodbody <andrew.goodb...@linaro.org>

Reply via email to