On Fri, Jul 25, 2025 at 05:30:59PM +0200, Quentin Schulz wrote: > Hi Tom, > > On 7/25/25 5:18 PM, Tom Rini wrote: > > On more recent versions of setuptools the warning about not being able > > to find the files specified in license_files has re-appeared. This is > > because as best I can tell, it can't and won't look in $(srctree) but > > rather only subdirectories of scripts/dtc/pylibfdt. Since we already > > provide both SPDX tags and a license field with the SPDX contents, let > > us just drop license_files as it's not mandatory. > > > > IANAL but I believe we need to ship the file, that's part of the license > requirements for both GPL-2.0-or-later and BSD-2-Clause.
I mean, we who? As part of "we should re-examine how we bundle Python stuff", yes, I don't know if our pylibfdt stuff is at all optimal anymore and we should maybe we talking with upstream dtc more. But $(srctree)/Licenses/gpl-2.0.txt and $(srctree)/Licenses/bsd-2-clause.txt exist and we don't publish the python binaries. > Can you try with a relative path, like ../../../ in front of Licenses? Yes, and I also tried telling swig -I$(srctree) to no effect. > If not enough, it's possible it's because it cannot read in parent > directories? What if we have a symlink, does it copy the symlink or the > target of the symlink? That would break on read-only source tree (Azure CI). > Reading https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html, > the license_files should then be automatically included in the sdist > tarball, so the presence of the files in it shouldn't be an issue here. We don't make sdist tarballs however. -- Tom
signature.asc
Description: PGP signature
