Hi,
On 25.07.25 15:55, Tom Rini wrote:
> On Fri, Jul 25, 2025 at 12:35:40PM +0200, Benjamin Hahn wrote:
>
>> Add new imx8mp-libra-fpsc board.
>> USB is not working yet, as the entry in the upstream devicetree is
>> missing.
>>
>> Signed-off-by: Benjamin Hahn <b.h...@phytec.de>
>> ---
>> arch/arm/dts/imx8mp-libra-rdk-fpsc-u-boot.dtsi | 78 +
>> arch/arm/mach-imx/imx8m/Kconfig | 9 +
>> board/phytec/imx8mp-libra-fpsc/Kconfig | 16 +
>> board/phytec/imx8mp-libra-fpsc/MAINTAINERS | 8 +
>> board/phytec/imx8mp-libra-fpsc/Makefile | 10 +
>> board/phytec/imx8mp-libra-fpsc/imx8mp-libra-fpsc.c | 114 ++
>> .../phytec/imx8mp-libra-fpsc/imx8mp-libra-fpsc.env | 30 +
>> board/phytec/imx8mp-libra-fpsc/lpddr4_timing.c | 1846
>> ++++++++++++++++++++
>> board/phytec/imx8mp-libra-fpsc/spl.c | 131 ++
>> configs/imx8mp-libra-fpsc_defconfig | 170 ++
>> include/configs/imx8mp-libra-fpsc.h | 27 +
>> 11 files changed, 2439 insertions(+)
>>
>> diff --git a/arch/arm/dts/imx8mp-libra-rdk-fpsc-u-boot.dtsi
>> b/arch/arm/dts/imx8mp-libra-rdk-fpsc-u-boot.dtsi
>> new file mode 100644
>> index 000000000000..8f0f86d9f09e
>> --- /dev/null
>> +++ b/arch/arm/dts/imx8mp-libra-rdk-fpsc-u-boot.dtsi
>> @@ -0,0 +1,78 @@
>> +// SPDX-License-Identifier: GPL-2.0-or-later
>> +/*
>> + * Copyright (C) 2025 PHYTEC Messtechnik GmbH
>> + */
>> +
>> +#include "imx8mp-u-boot.dtsi"
>> +
>> +/ {
>> + wdt-reboot {
>> + compatible = "wdt-reboot";
>> + wdt = <&wdog1>;
>> + bootph-pre-ram;
>> + };
>> +};
>> +
>> +®_usdhc2_vmmc {
>> + bootph-pre-ram;
>> +};
> Please note the bootph tags should be upstreamed.
Is this something new? Is this documented somewhere? Up until now, this
was always done in *-u-boot.dtsi for all boards. Only very recently some
k3 boards seem to have added bootph tags in kernel devicetrees.
Why is this switched to kernel devicetree now? As far I saw, the kernel
does not use / do anything with the bootph tags. To me it looks like
this is something for U-Boot and not something that the Kernel uses, so
I would expect this to be in u-boot.dtsi.
>
> [snip]
>> diff --git a/board/phytec/imx8mp-libra-fpsc/MAINTAINERS
>> b/board/phytec/imx8mp-libra-fpsc/MAINTAINERS
>> new file mode 100644
>> index 000000000000..16b18b605e0d
>> --- /dev/null
>> +++ b/board/phytec/imx8mp-libra-fpsc/MAINTAINERS
>> @@ -0,0 +1,8 @@
>> +Libra-i.MX 8M Plus
>> +M: Teresa Remmet <t.rem...@phytec.de>
>> +W:
>> https://www.phytec.eu/en/produkte/system-on-modules/phycore-imx-8m-plus-fpsc/
>> +S: Maintained
>> +F: arch/arm/dts/imx8mp-libra-rdk-fpsc-u-boot.dtsi
>> +F: board/phytec/imx8mp-libra-fpsc/
>> +F: configs/imx8mp-libra-fpsc_defconfig
>> +F: include/configs/imx8mp-libra-fpsc.h
> These should all be tabs.
Will do.
>
> [snip]
>> diff --git a/board/phytec/imx8mp-libra-fpsc/imx8mp-libra-fpsc.c
>> b/board/phytec/imx8mp-libra-fpsc/imx8mp-libra-fpsc.c
>> new file mode 100644
>> index 000000000000..89b3b6f90ecb
>> --- /dev/null
>> +++ b/board/phytec/imx8mp-libra-fpsc/imx8mp-libra-fpsc.c
>> @@ -0,0 +1,114 @@
>> +// SPDX-License-Identifier: GPL-2.0-or-later
>> +/*
>> + * Copyright (C) 2025 PHYTEC Messtechnik GmbH
>> + */
>> +
>> +#include <asm/arch/clock.h>
>> +#include <asm/arch/sys_proto.h>
>> +#include <asm/global_data.h>
>> +#include <linux/io.h>
>> +#include <asm/mach-imx/boot_mode.h>
>> +#include <dwc3-uboot.h>
>> +#include <env.h>
>> +#include <init.h>
>> +#include <fdt_support.h>
>> +#include <jffs2/load_kernel.h>
>> +#include <miiphy.h>
>> +#include <mtd_node.h>
>> +#include <usb.h>
>> +#include <i2c.h>
>> +
>> +#if IS_ENABLED(CONFIG_PHYTEC_SOM_DETECTION)
>> +#include "../common/imx8m_som_detection.h"
>> +#endif
>> +
>> +DECLARE_GLOBAL_DATA_PTR;
> Please audit this, gd isn't referenced for example. Thanks.
I will delete this line.
Regards, Benjamin
