Smatch reported two issues with this driver. Firstly a direct return instead of using an unwind goto and secondly a test for a condition guaranteed to be true by an earlier test.
Signed-off-by: Andrew Goodbody <andrew.goodb...@linaro.org> --- Andrew Goodbody (2): net: dwc_eth_xgmac: Use unwind goto on error net: dwc_eth_xgmac_socfpga: Remove always true test drivers/net/dwc_eth_xgmac.c | 2 +- drivers/net/dwc_eth_xgmac_socfpga.c | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) --- base-commit: ae5711f881100f856ead1e76832c32b92dba93c7 change-id: 20250804-dwc_eth-265d9bdc33fe Best regards, -- Andrew Goodbody <andrew.goodb...@linaro.org>