On Fri, 25 Jul 2025 11:41:12 +0100, Andrew Goodbody wrote:
> The function dev_read_u32_default does not return an error and the
> variable 'val' is unsigned so testing for >= 0 will always be true. It
> looks like the code was attempting to return -1 if xtal-load-pf was not
> present but that cannot work. Instead use dev_read_u32 which returns an
> error code separately from writing the value into the passed pointer.
>
> This issue was found by Smatch.
>
> [...]
Applied to u-boot/next, thanks!
[1/1] clk: cdce9xx: Fix use of dev_read_u32_default
commit: bd644d9613ee0cdc3bd2ac3bc7bcc52b09d821e7
--
Tom
