In k3_nav_ringacc_probe_dt there can be no error code returned from
dev_read_u32_default so ret is not assigned to and should not be used.
Remove the use of ret from the dev_err call as it is unitialised.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodb...@linaro.org>
---
 drivers/soc/ti/k3-navss-ringacc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/ti/k3-navss-ringacc.c 
b/drivers/soc/ti/k3-navss-ringacc.c
index ac29158d489..d37c454143b 100644
--- a/drivers/soc/ti/k3-navss-ringacc.c
+++ b/drivers/soc/ti/k3-navss-ringacc.c
@@ -932,7 +932,7 @@ static int k3_nav_ringacc_probe_dt(struct k3_nav_ringacc 
*ringacc)
 
        ringacc->num_rings = dev_read_u32_default(dev, "ti,num-rings", 0);
        if (!ringacc->num_rings) {
-               dev_err(dev, "ti,num-rings read failure %d\n", ret);
+               dev_err(dev, "ti,num-rings read failure\n");
                return -EINVAL;
        }
 

-- 
2.39.5

Reply via email to