On Tue, Aug 12, 2025 at 09:22:24AM -0600, Tom Rini wrote: > [EXTERNAL MAIL]
> Date: Tue, 12 Aug 2025 09:22:24 -0600 > From: Tom Rini <tr...@konsulko.com> > To: Leo Liang <ycli...@andestech.com> > Cc: u-boot@lists.denx.de, r...@andestech.com, > heinrich.schucha...@canonical.com, ben.do...@codethink.co.uk, > jamie.gibb...@microchip.com, sput...@on-the-web.ch, michal.si...@amd.com > Subject: Re: [GIT PULL] u-boot-riscv/master > > On Tue, Aug 12, 2025 at 04:04:49PM +0800, Leo Liang wrote: > > > Hi Tom, > > > > The following changes since commit acfacf452441d0a659e3afbd55fd6061aa17e647: > > > > Prepare v2025.10-rc2 (2025-08-11 13:47:46 -0600) > > > > are available in the Git repository at: > > > > https://source.denx.de/u-boot/custodians/u-boot-riscv.git > > > > for you to fetch changes up to bddcd6bcba081aaaaafe30d1b8f9f3c83f069bde: > > > > starfive: fix return code of `mac write_eeprom` (2025-08-12 15:34:39 > > +0800) > > > > CI result shows no issue: > > https://source.denx.de/u-boot/custodians/u-boot-riscv/-/pipelines/27348 > > ---------------------------------------------------------------- > > - Board: mbv: Prepare MBV for CI > > - Board: MPFS Icicle Kit cleanup > > - Board: Add Andes Voyager board support > > - RISCV: Update SYS_BOOTM_LEN to commonly used value > > - starfive: fix return code of `mac write_eeprom` > > So, there's a few problems here. First, checkpatch.pl finds spacing and > spelling issues, which I would normally just fixup in place. But second, > voyager_spl doesn't build: > riscv64: + voyager_spl > +(voyager_spl) In file included from include/linux/printk.h:4, > +(voyager_spl) from include/linux/kernel.h:5, > +(voyager_spl) from include/linux/libfdt_env.h:13, > +(voyager_spl) from include/linux/libfdt.h:6, > +(voyager_spl) from include/fdtdec.h:17, > +(voyager_spl) from include/dm/ofnode.h:11, > +(voyager_spl) from include/dm/device.h:13, > +(voyager_spl) from include/dm.h:13, > +(voyager_spl) from common/spl/spl.c:13: > +(voyager_spl) common/spl/spl.c: In function 'spl_set_header_raw_uboot': > +(voyager_spl) common/spl/spl.c:281:27: error: format '%x' expects argument > of type 'unsigned int', but argument 2 has type 'long int' [-Werror=format=] > +(voyager_spl) 281 | log_debug("Default load addr %x > (u_boot_pos=%lx)\n", > +(voyager_spl) | > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > +(voyager_spl) include/log.h:234:24: note: in definition of macro 'log' > +(voyager_spl) 234 | printf(_fmt, ##_args); \ > +(voyager_spl) | ^~~~ > +(voyager_spl) common/spl/spl.c:281:17: note: in expansion of macro > 'log_debug' > +(voyager_spl) | ^~~~~~~~~ > +(voyager_spl) common/spl/spl.c:281:47: note: format string is defined here > +(voyager_spl) | ~^ > +(voyager_spl) | | > +(voyager_spl) | unsigned > int > +(voyager_spl) | %lx > +(voyager_spl) cc1: all warnings being treated as errors > +(voyager_spl) make[3]: *** [scripts/Makefile.build:296: > spl/common/spl/spl.o] Error 1 > +(voyager_spl) make[2]: *** [scripts/Makefile.xpl:547: spl/common/spl] Error 2 > +(voyager_spl) make[1]: *** [Makefile:2358: spl/u-boot-spl] Error 2 > +(voyager_spl) make: *** [Makefile:198: sub-make] Error 2 > > Please fix and re-submit, thanks. Hi Tom, Sorry! I will fix these and re-submit ASAP. Best regards, Leo > > -- > Tom
