Re: [PATCH v1] pcie: starfive: Fix the incorrect use of dev_err()

[Fabio Estevam]

On Wed, Aug 27, 2025 at 11:26 AM Hal Feng <hal.f...@starfivetech.com> wrote:
>
> Use dev_info() instead of dev_err() when finishing the probe function.
>
> Signed-off-by: Hal Feng <hal.f...@starfivetech.com>
> ---
>  drivers/pci/pcie_starfive_jh7110.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pcie_starfive_jh7110.c 
> b/drivers/pci/pcie_starfive_jh7110.c
> index 51aca7359ff..f2256307ab3 100644
> --- a/drivers/pci/pcie_starfive_jh7110.c
> +++ b/drivers/pci/pcie_starfive_jh7110.c
> @@ -292,7 +292,7 @@ static int starfive_pcie_probe(struct udevice *dev)
>         if (ret)
>                 return ret;
>
> -       dev_err(dev, "Starfive PCIe bus probed.\n");
> +       dev_info(dev, "StarFive PCIe bus probed\n");

Or maybe remove this line.

We don't need drivers stating that they probed successfully.

Probe errors are helpful to print; probe success is not.