Liew Tsi Chung wrote: > Ben, > > >> Right, so there's no need to mention them in C code. Less is >> more, as they say. >> > Agree. > > So, everything ok now? > > I haven't seen the patch that removes the prototypes, but it's quite possible I looked past it. In a previous e-mail I added a 'signed-off-by' that John Rigby can add to the patch commit. I consider this to be a Coldfire patch because it's dependent on other patches in the series and I have no way of testing it.
I hope that's OK. regards, Ben > Regards, > TsiChung > > -----Original Message----- > From: Ben Warren [mailto:[EMAIL PROTECTED] > Sent: Thursday, January 17, 2008 12:27 PM > To: Liew Tsi Chung > Cc: U-Boot-Users; Wolfgang Denx; Rigby John > Subject: Re: [U-Boot-Users] resend#3 [PATCH 6/8] ColdFire: Add > MCF547x_8x FEC driver > > Liew Tsi Chung wrote: > >> Ben, >> >> The prototypes have place in include/asm-m68k/fsl_mcdmafec.h. >> >> Regards, >> TsiChung >> >> >> > Right, so there's no need to mention them in C code. Less is more, as > they say. > > regards, > Ben > > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
