On Friday 15 February 2008, Kumar Gala wrote: > --- /dev/null > +++ b/lib_ppc/cmd_call.c
there's nothing ppc specific about this
> + if ((argc < 2) || (argc > 10)) {
> ...
> +U_BOOT_CMD(
> + call, CFG_MAXARGS, 1, do_call,
considering the u-boot infrastructure for commands will do the max checking
for you, there's no need to check the upper bound of argc. it's also out of
sync: in one place you have a random "10" but in another you
have "CFG_MAXARGS".
> + (*img)(r[0], r[1], r[2], r[3], r[4], r[5], r[6], r[7]);
> +
> + /* may not return */
> +
> + return 0;
why not ? you might as well not arbitrarily limit things and have the
prototype return an int and have it return that instead of "0":
return (*img)(r[0], r[1], r[2], r[3], r[4], r[5], r[6], r[7]);
-mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
