On Tue, Mar 18, 2008 at 11:42 AM, Shinya Kuribayashi
<[EMAIL PROTECTED]> wrote:
> Signed-off-by: Shinya Kuribayashi <[EMAIL PROTECTED]>
>  ---
>  +       while (1) {
>  +               cache_op(Hit_Writeback_Inv_D, start_addr);
>  +               if (addr == aend)
>  +                       break;
>  +               addr += lsize;
>  +       }

looking at how cache_flush() is used (see common/cmd_load.c,
common/cmd_elf.c, etc), I believe this loop should also do a cache_op
with Hit_Invalidate_I to invalidate the icache.

seems like it would be easier to read if the condition was included in
the while() statement


-- 
Hardware, n.:
 The parts of a computer system that can be kicked.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Reply via email to