Tsi-Chung Liew wrote:
> + /*
> + * FEC fix for MCF5275, FEC unable to initial transmit data packet.
> + * A nop will ensure the descriptor polling active completed.
> + */
> +#ifdef CONFIG_M5275
> + __asm__ ("nop");
> +#endif
> +
> #ifdef CFG_UNIFY_CACHE
> icache_invalid();
> #endif
At the risk of being very picky, I think this should be
written to have the comment inside the #ifdef so that
the code and comment are not accidentally separated.
#if defined(CONFIG_M5275)
/*
* FEC ...
*/
__asm__("nop");
#endif
But, that may be just me. Take it or leave it. :-)
jdl
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
