Wolfgang Denk wrote:
> Dear Aras,
>
> in message <[EMAIL PROTECTED]> you wrote:
>> This patch changes the "usb storage" command to return success iff it
>> finds a USB storage device, otherwise it returns error.
>
> Thanks. I appreciate your contribution, but please fix the coding
> style:
>
>> @@ -196,9 +196,13 @@
>> for (i = 0; i < usb_max_devs; i++) {
>
> There is probably a { missing before this line (as this is not a
> single-line statement).
>
>> printf (" Device %d: ", i);
>> dev_print(&usb_dev_desc[i]);
>> + return 0;
>> }
>> else
>> + {
>
> ...and then this should read
>
> } else {
>
> Thanks.
>
> Best regards,
>
> Wolfgang Denk
Just in case Wolfgang was too terse, I'll add to his critique... the
original code is the origin of the coding violations:
void usb_stor_info(void)
{
int i;
if (usb_max_devs > 0)
for (i = 0; i < usb_max_devs; i++) {
printf (" Device %d: ", i);
dev_print(&usb_dev_desc[i]);
}
else
printf("No storage devices, perhaps not 'usb
start'ed..?\n");
}
It doesn't have braces on the "if (usb_max_devs > 0)" which is
syntactically OK but the source of the coding violation. Please add
braces after the "if" and "} else {" per Wolfgang's comments.
Thanks for making the code a little better and a little prettier, ;-)
gvb
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
