On Mon, Mar 24, 2008 at 06:00:49PM -0500, Kim Phillips wrote:
> On Mon, 24 Mar 2008 17:44:19 +0300
> Anton Vorontsov <[EMAIL PROTECTED]> wrote:
>
> > On Wed, Mar 19, 2008 at 08:35:58PM -0500, Kim Phillips wrote:
> > > On Fri, 14 Mar 2008 23:20:18 +0300
> > > Anton Vorontsov <[EMAIL PROTECTED]> wrote:
> > >
> > >
> > > > diff --git a/include/fdt_support.h b/include/fdt_support.h
> > > > index 7836f28..c10de8a 100644
> > > > --- a/include/fdt_support.h
> > > > +++ b/include/fdt_support.h
> > > > @@ -50,6 +50,12 @@ int fdt_find_and_setprop(void *fdt, const char
> > > > *node, const char *prop,
> > > > const void *val, int len, int create);
> > > > void fdt_fixup_qe_firmware(void *fdt);
> > > >
> > > > +#ifdef CONFIG_HAS_FSL_DR_USB
> > > > +void fdt_fixup_dr_usb(void *blob, bd_t *bd);
> > > > +#else
> > > > +static inline void fdt_fixup_dr_usb(void *blob, bd_t *bd) {}
> > > > +#endif /* CONFIG_HAS_FSL_DR_USB */
> > > > +
> > >
> > > this looks like a prime candidate for a weak function (which would also
> > > eliminate the need for the new CONFIG_HAS_FSL_DR_USB introduced here).
> >
> > Are you sure it's supposed to work like this?.. I don't see the linker
> > dropping unused weak symbols with the patch below.
>
> with something like the following I get 24 bytes more text in
> fdt_support.o, and 200 total bytes added 83xx-wide:
>
[...]
> but the QE based 83xx SoCs don't use this fixup. So while
> CONFIG_HAS_FSL_DR_USB gives you more control, I doubt saving 200 bytes
> justifies the new config either. Either way really, but I tend to be
> against any new CONFIG_s.
Hm... maybe then it's better to place fdt_fixup_usb_dr function
inside the fdt_support.h, marking it with static inline -- it's used
just once per board anyway..? Then neither space wasted nor the new
configs introduced.
--
Anton Vorontsov
email: [EMAIL PROTECTED]
irc://irc.freenode.net/bd2
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
