You are right! I've checked it again and find the mistake by myself.
Subject: [PATCH] bugfix: lwmon5 watchdog post
If the hardware watchdog detects a voltage error, the watchdog set GPIO62 to
low.
The watchdog POST have to detect this lowpegel.
Signed-off-by: Sascha Laue <[EMAIL PROTECTED]>
---
post/board/lwmon5/watchdog.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/post/board/lwmon5/watchdog.c b/post/board/lwmon5/watchdog.c
index 48ff687..899fbfb 100644
--- a/post/board/lwmon5/watchdog.c
+++ b/post/board/lwmon5/watchdog.c
@@ -55,7 +55,7 @@ static void watchdog_magic_write(uint value)
int sysmon1_post_test(int flags)
{
- if (gpio_read_in_bit(CFG_GPIO_SYSMON_STATUS)) {
+ if (gpio_read_in_bit(CFG_GPIO_SYSMON_STATUS) == 0) {
/*
* 3.1. GPIO62 is low
* Assuming system voltage failure.
--
1.5.2.4
-------- Original-Nachricht --------
> Datum: Tue, 01 Apr 2008 10:33:20 +0200
> Von: Wolfgang Denk <[EMAIL PROTECTED]>
> An: "Sascha Laue" <[EMAIL PROTECTED]>
> CC: u-boot-users@lists.sourceforge.net
> Betreff: Re: [U-Boot-Users] [PATCH] bugfix: the watchdog post for lwmon5
> In message <[EMAIL PROTECTED]> you wrote:
> > bugfix: the watchdog post for lwmon5 doesn't work. This Patch fix it.
> > To trigger and activate the watchdog correct it is necessary to create 2
> pulses.
> > Lowpegel on GPIO62 point to a voltagefailure.
>
> Please fix English ("correct", "Lowpegel", "voltagefailure").
>
> Is it really 2 pulses - or just one, consisting of
>
> > Signed-off-by: Sascha Laue <[EMAIL PROTECTED]>
> ...
> > - if (gpio_read_in_bit(CFG_GPIO_SYSMON_STATUS)) {
> > + if (0 == gpio_read_in_bit(CFG_GPIO_SYSMON_STATUS)) {
>
> Please write that as:
>
> if (gpio_read_in_bit(CFG_GPIO_SYSMON_STATUS) == 0) {
> or
> if (!gpio_read_in_bit(CFG_GPIO_SYSMON_STATUS)) {
>
> > * 3.1. GPIO62 is low
> > * Assuming system voltage failure.
> > @@ -99,6 +99,9 @@ int lwmon5_watchdog_post_test(int flags)
> > ints = disable_interrupts ();
> > /* 3.2.2. strobe watchdog once */
> > WATCHDOG_RESET();
> > + base = post_time_ms (0);
> > + while (post_time_ms (base) < 2)
> > + WATCHDOG_RESET();
>
> Are you absolutely sure that is needed?
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
> Tactical? TACTICAL!?!? Hey, buddy, we went from kilotons to megatons
> several minutes ago. We don't need no stinkin' tactical nukes. (By
> the way, do you have change for 10 million people?) - lwall
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
