On 23:01 Tue 08 Apr , Wolfgang Denk wrote: > In message <[EMAIL PROTECTED]> you wrote: > > ds174x.c: In function 'rtc_get': > > ds174x.c:117: warning: no return statement in function returning non-void > > ds174x.c: In function 'rtc_set': > > ds174x.c:146: warning: 'return' with a value, in function returning void > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[EMAIL PROTECTED]> > > > > diff --git a/drivers/rtc/ds174x.c b/drivers/rtc/ds174x.c > > index 81a9cb3..eb3ca88 100644 > > --- a/drivers/rtc/ds174x.c > > +++ b/drivers/rtc/ds174x.c > > @@ -114,6 +114,7 @@ int rtc_get( struct rtc_time *tmp ) > > tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday, > > tmp->tm_hour, tmp->tm_min, tmp->tm_sec ); > > #endif > > + return 0; > > } > > > > void rtc_set( struct rtc_time *tmp ) > > @@ -142,8 +143,6 @@ void rtc_set( struct rtc_time *tmp ) > > > > /* unlock clock registers after read */ > > rtc_write( RTC_CONTROLA, ( reg_a & ~RTC_CA_WRITE )); > > - > > - return 0; > > } > > > > void rtc_reset (void) > > I think this is actually not the right fix. > > To make things right, both rtc_set() and rtc_get() should return > "int". > > Yes, I'm aware that this is far beyond the scope of your fixes here, > but I wanted to at least note that. > > Note that this is no NAK. > I can add it in my task for this fix window or in the next merge windows
Best Regards, J. ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
