Hi Wolfgang, On Sun, Apr 20, 2008 at 2:36 AM, Wolfgang Denk <[EMAIL PROTECTED]> wrote: > > Dear Ben, > > this patch is still on my "open" list. Can you please review and > apply if it makes sense to you? Thanks. >
This looks OK to me. Assuming that pci_io_to_phys() is defined on all relevant architectures, I have no objections. Unfortunately I can't run MAKEALL right now, so if it's not too much of a bother please pull directly. We can always pull it out if there's a problem, I guess. regards, Ben > ------- Forwarded Message > > Date: Wed, 10 Oct 2007 23:02:09 +0300 > From: Vlad Lungu <[EMAIL PROTECTED]> > To: u-boot-users@lists.sourceforge.net, [EMAIL PROTECTED] > Subject: [PATCH] Fixed pcnet io_base > > Bus and phys address are not always the same > > Signed-off-by: Vlad Lungu <[EMAIL PROTECTED]> > --- > drivers/pcnet.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/pcnet.c b/drivers/pcnet.c > index 2af0e8f..22edb48 100644 > --- a/drivers/pcnet.c > +++ b/drivers/pcnet.c > @@ -196,6 +196,7 @@ int pcnet_initialize(bd_t *bis) > * Setup the PCI device. > */ > pci_read_config_dword(devbusfn, PCI_BASE_ADDRESS_0, (unsigned int > *)&de > v->iobase); > + dev->iobase=pci_io_to_phys(devbusfn,dev->iobase); > dev->iobase &= ~0xf; > > PCNET_DEBUG1("%s: devbusfn=0x%x iobase=0x%x: ", > -- > 1.5.2.2 > > ------- End of Forwarded Message > > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] > Where a calculator on the ENIAC is equipped with 18,000 vacuum tubes > and weighs 30 tons, computers in the future may have only 1,000 > vacuum tubes and weigh only 1/2 tons. - Popular Mechanics, March 1949 > ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users