In message <[EMAIL PROTECTED]> you wrote: > Current flush_cache code does > > 1. clean the dcache with dcbst, but not invalidate dcache > 2. invalidate icache > > This patch use the dcbf instead of dcbst to have stronger > semantic, clean the dcache and invalidate dcache.
On which processors did you test the changes? I have some unclear memories of dcbf having problems on for example MPC8xx ? > We have two options: > > 1. Separate functions for them like linux kernel. > A. clean dcache (dcbst) for DMA_TO_DEVICE > B. invalidate dcache (dcbi) for DMA_FROM_DEVICE > C. flush dcache (dcbf) for DMA_BIDIRECTIONAL. > 2. Make current flush_cache stronger semanctic. > use the dcbf instead of dcbst. > > Which one is better? or you have better option? > Please suggest. We discussed this a bit on IRC; Kumar suggested to go for 1., and I agree. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] "I believe the use of noise to make music will increase until we reach a music produced through the aid of electrical instruments which will make available for musical purposes any and all sounds that can be heard." - composer John Cage, 1937 ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
