In message <[EMAIL PROTECTED]> you wrote:
> ---
> board/amcc/kilauea/init.S | 53 +++++++++++--
> board/amcc/makalu/init.S | 53 +++++++++++--
> cpu/ppc4xx/Makefile | 1 +
> cpu/ppc4xx/ecc.S | 195
> +++++++++++++++++++++++++++++++++++++++++++++
> cpu/ppc4xx/sdram.c | 47 +----------
> 5 files changed, 292 insertions(+), 57 deletions(-)
There are a couple of problems with your posting:
- there is no signed-off-by line
- there is no explanation what you're actually trying to
add or to fix.
- there are coding style violations: C++ comments, trailing white
space, ...
- the code contains way too many empty lines / vertical white space.
- even in pseudo code, the Coding style requirements apply; i. e.
instead of
+ /*
+ * if (start >= end) {
+ * return;
+ * }
+ */
please write
+ /*
+ * if (start >= end)
+ * return;
+ */
etc.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Your own mileage may vary.
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
U-Boot-Users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/u-boot-users
