On Tue, 2008-05-06 at 16:04 +0200, Remy Bohmer wrote: > Hello, > > > > uhh, I tested/using it... And it is working properly now without this > > > commit... (So, it fixes the problem I had here) > > I meant if reverted, it will never be fixed properly. > > Then we agree, but leaving it in without a fix, makes the next release > of U-boot quite buggy on these boards... > > > > > What happens if you modify to this: > > > > if ((gd->flags & GD_FLG_RELOC) && (gd->env_valid == 1)) > > In that case it will not help, because GD_FLG_RELOC is _not_ set on > this board, so the 'if' will never become 'true'. > So, I made it an || and that works...
This makes me think that the test should perhaps only test gd->env_valid: if (gd->env_valid == 1) Not sure and I am busy ATM. Curious, why isn't GD_FLG_RELOC set on you board? > > I will post a patch immediately in a separate mail. > > > Kind Regards, > > Remy > ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
