Anton Vorontsov wrote: > On Mon, May 05, 2008 at 08:41:59PM +0200, Stefan Roese wrote: >> On Monday 05 May 2008, Larry Johnson wrote: >>>>> Yes, I totally agree. Patches should *not* change the default behavior. >>>>> We should change it as you suggested. Sorry, I must have missed this. >>>>> >>>>> Nobuhiro, could you please send a new patch to fix this problem? >>>> Thank you for your check. >>>> It has troubled you with my patch. >>>> >>>> I rewirte new patch . Could you please check this patch and confirming >>>> the work? >>>> >>>> Best regards, >>>> Nobuhiro >>> Hi Nobuhiro, Stefan, and everyone, >>> >>> Sorry for the delay in getting back to you. My mail reader thinks your >>> patch is part of your signature, so I missed it the first time around. >>> >>> I did a quick check using the Sequoia board, and it looks like the patch >>> isn't working there. U-Boot is reporting the class of the bridge as >>> "0680", which I assume is why the patch doesn't skip it. >> Yes, I just gave the new patch a try and noticed (still) a problem on >> Sequoia. >> The PCI host bridge (PPC) is listed upon bootup which was not the case with >> the U-Boot version prior to the first patch. >> >>> Nobuhiro and Stefan, do you think we can get a working fix for this into >>> 1.3.3 (even if it is not the final fix)? >> I definitely hope so. Even though I will probably not find the time to >> submit >> a patch to really fix this problem till the scheduled release date. But I >> will gladly test a patch. :) >> >>> If not, we should patch >>> Sequoia and Korat to add CONFIG_PCI_SKIP_HOST_BRIDGE so they won't be >>> broken in that release. >> Or perhaps we should revert the first patch and give it another try in the >> next merge-window when/if a new patch is available. > > Yes, please. That patch also broke probably all Freescale PowerPC boards. > Particularly, without #define CONFIG_PCI_SKIP_HOST_BRIDGE I'm getting > these errors from the Linux using PCI 3com driver: > > eth4: Host error, FIFO diagnostic register 0000. > eth4: PCI bus error, bus status 80000020 > eth4: setting full-duplex. > [infinite times] > > This is MPC8315E-RDB.
At this point, I'm in favor of reverting the patch for this release and letting Nobuhiro put in a temporary board-specific patch for those boards that need the modified functionality. The if we do a non-board-specific patch for the next window, we won't be rushed to make sure it doesn't break any boards. Best regards, Larry ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
