On May 9, 2008, at 2:14 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 14:45 Fri 09 May , Jerry Van Baren wrote:
>> Becky Bruce wrote:
>>> On May 9, 2008, at 10:28 AM, Scott Wood wrote:
>>>> On Thu, May 08, 2008 at 07:02:23PM -0500, [EMAIL PROTECTED]
>>>> wrote:
>>>>> diff --git a/include/asm-ppc/mmu.h b/include/asm-ppc/mmu.h
>>>>> index 49d6860..f836270 100644
>>>>> --- a/include/asm-ppc/mmu.h
>>>>> +++ b/include/asm-ppc/mmu.h
>>>>> @@ -141,6 +141,10 @@ extern void _tlbia(void); /* invalidate
>>>>> all
>>>>> TLB entries */
>>>>> typedef enum {
>>>>> IBAT0 = 0, IBAT1, IBAT2, IBAT3,
>>>>> DBAT0, DBAT1, DBAT2, DBAT3
>>>>> +#ifdef CONFIG_HIGH_BATS
>>>>> + , IBAT4, IBAT5, IBAT6, IBAT7,
>>>>> + DBAT4, DBAT5, DBAT6, DBAT7
>>>>> +#endif
>>>> C allows trailing commas on such lists; no need to move it inside
>>>> the
>>>> ifdef.
>>>
>>> Dangling commas bother me in the extreme. If this is the concensus,
>>> I'll move it, but I prefer it where it is.
>>>
>>> -B
>>
>> +1 for moving. Dangling commas is the second best thing in C. ;-)
> +1 for moving. Dangling commas is the second best thing in C. ;-)
>
I also want to know what's the first best thing! I have to guess that
the dangling comma is really the fifteenth-best thing, or
something..... but I don't want this thread to degenerate into a holy
war.
Ayway, point taken, and I'll move it. But I don't have to like it :)
Cheers,
B
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
