On Mon, May 12, 2008 at 08:56:08AM -0500, Menon, Nishanth wrote: > Sascha, > > -----Original Message----- > > From: Sascha Hauer [mailto:[EMAIL PROTECTED] > > Sent: Monday, May 12, 2008 8:44 AM > > To: Menon, Nishanth > > Cc: [email protected] > > Subject: Re: [Patch 1/2] U-Boot-V2: ARM: Makefile cleaup > > > > > +AFLAGS += -msoft-float -Os > > > > Assemblers don't know about soft-float and size optimisation. This patch > > only works because AFLAGS is unused. Besides, you shouldn't use floating > > point througout U-Boot anyway. > I agree on the -Os being unused. On -msoft-float without the same in AFLAGS: > arm-none-eabi-ld: ERROR: arch/arm/mach-omap/omap3_clock.o uses hardware FP, > whereas arch/arm/mach-omap/built-in.o uses software FP > arm-none-eabi-ld: failed to merge target specific data of file > arch/arm/mach-omap/omap3_clock.o > make[1]: *** [arch/arm/mach-omap/built-in.o] Error 1 > make: *** [arch/arm/mach-omap] Error 2
Hm, just tried with a hardfloat toolchain, I get the same error. I'm wondering why we have a -msoft-float in CFLAGS anyway. Removing it works for hard- and softfloat toolchains and shouldn't make a difference. > > Ideally the gcc flags should be set per platform -> Linux kernel has a neat > manner of doing it. We can move ahead with h/w FP as long as we allow flags > to be set for platform. Currently though, if C files are compiled with > -msoft-float, so should AFLAGS. Probably we need some new management of > compiler flags? Not exactly new, because I've taken much from the linux kernel. But they sure could use a general cleanup. Sascha -- Pengutronix e.K. - Linux Solutions for Science and Industry ----------------------------------------------------------- Kontakt-Informationen finden Sie im Header dieser Mail oder auf der Webseite -> http://www.pengutronix.de/impressum/ <- ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ U-Boot-Users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/u-boot-users
