On Wed, 21 May 2008 15:34:32 +0200 Wolfgang Denk <[EMAIL PROTECTED]> wrote:
> In message <[EMAIL PROTECTED]> you wrote: > > > > Unfortunately several wrong fixes or false positives still remains, > > but this patch definitely reduce the number of wrong indentations. > > Could you please point out the remaining problems? If I understand > what's gone wrong I probably can fix my procedure and spin another > patch? > although the existing patch should definitely stay committed, here are a couple of examples of things I'd expect it to have fixed: board/freescale/mpc8349itx/mpc8349itx.c:120 board/freescale/mpc8349itx/mpc8349itx.c:275 board/freescale/mpc8349emds/pci.c:56 Also, although less authoritative (esp. for u-boot), linux-2.6/scripts/checkpatch.pl output is always interesting on these types of patches. I'll be sure to get some by hand - I understand these expressions sometimes get too unwieldly too fast. Kim ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
