In message <[EMAIL PROTECTED]> you wrote:
> ARM: This patch adds support for the Lyrtech SFF-SDR
> board, based on the TI DaVinci architecture (ARM926EJS).
>
> Signed-off-by: Hugo Villeneuve <[EMAIL PROTECTED]>
> Signed-off-by: Philip Balister <[EMAIL PROTECTED]>
There are a lot of new files, and you sign these off, but I don't see
your copyright notice in either of these. How comes? Didn't you modify
this code?
...
> diff --git a/include/configs/davinci_sffsdr.h
> b/include/configs/davinci_sffsdr.h
> new file mode 100644
> index 0000000..b62ea74
...
> +#define CONFIG_BOOTCOMMAND \
> + "setenv setboot setenv bootargs \\$(bootargs);run setboot"
Do not use the old "$(...)" syntax any more, it is deprecated. Please
use "${...}" instead.
Also, this statement is nonsense, as you don't do anything there that
has any effect.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
A committee is a group that keeps the minutes and loses hours.
-- Milton Berle
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
U-Boot-Users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/u-boot-users
