On Sunday 01 June 2008, Wolfgang Denk wrote: > What is the licensing of this file, and who is the Copyright holder?
it's all ADI written and owned. we dont particularly care about the license, but i guess i can tag it GPL-2. > > diff --git > > a/include/asm-blackfin/mach-bf538/ADSP-EDN-BF538-extended_def.h > > b/include/asm-blackfin/mach-bf538/ADSP-EDN-BF538-extended_def.h new file > > mode 100644 > > index 0000000..4e36fb9 > > --- /dev/null > > +++ b/include/asm-blackfin/mach-bf538/ADSP-EDN-BF538-extended_def.h > > @@ -0,0 +1,1121 @@ > > +/* DO NOT EDIT THIS FILE > > + * Automatically generated by generate-def-headers.xsl > > + * DO NOT EDIT THIS FILE > > + */ > > Do we really (I mean: really, really!) need all the 1121 lines of this > crap^H^H^H^Hstuff? yes > Please use tabs for indentation and alignment!! it's going to introduce a lot of whitespace churn ... i dont care, but i imagine you're going to complain when i fix existing files > Hm.... looking at such a file is horrible: > > +#define bfin_read_MXVR_PLL_CTL_0() bfin_read32(MXVR_PLL_CTL_0) > > +#define bfin_write_MXVR_PLL_CTL_0(val) bfin_write32(MXVR_PLL_CTL_0, val) > > +#define pMXVR_STATE_0 ((uint32_t volatile > > *)MXVR_STATE_0) /* MXVR State Register 0 */ +#define > > bfin_read_MXVR_STATE_0() bfin_read32(MXVR_STATE_0) +#define > > bfin_write_MXVR_STATE_0(val) bfin_write32(MXVR_STATE_0, val) +#define > > pMXVR_STATE_1 ((uint32_t volatile *)MXVR_STATE_1) /* > > MXVR State Register 1 */ +#define bfin_read_MXVR_STATE_1() > > bfin_read32(MXVR_STATE_1) +#define bfin_write_MXVR_STATE_1(val) > > bfin_write32(MXVR_STATE_1, val) +#define pMXVR_INT_STAT_0 > > ((uint32_t volatile *)MXVR_INT_STAT_0) /* MXVR Interrupt Status Register > > 0 */ +#define bfin_read_MXVR_INT_STAT_0() bfin_read32(MXVR_INT_STAT_0) > > I do not think that we should allow such code in U-Boot. it is the designed programming style for all low level Blackfin systems. it is unified across Linux, U-Boot, bare metal code, and the official ADI propriety compiler. i thought your point was to keep U-Boot and Linux the same at the API level so code sharing is very easy between it ? -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
