Sascha,
> -----Original Message-----
> From: Sascha Hauer [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, June 03, 2008 3:18 AM
> To: Menon, Nishanth
> Cc: Peter Pearse; [email protected]; Kamat, Nishant; Syed 
> Mohammed, Khasim; Laurent
> Desnogues; [EMAIL PROTECTED]
> Subject: Re: [Patch 11/17 Try 2] U-Boot-V2:ARM:OMAP3: Add support for 
> OMAP3Silicon files
> 
> On Wed, May 28, 2008 at 10:39:07AM -0500, Menon, Nishanth wrote:
> > As per the thread in:
> > http://www.nabble.com/-Patch-06-17--U-Boot-V2%3AARM%3A-Add-sizes.h-tt17372780.html#a17372780
> > sizes.h dependency is removed from the following patch. This is a 
> > resubmission.
> >
> > This patch introduces support for OMAP3430 - provides for generic OMAP3 
> > files.
> 
> Looks ok to me besides the occurences of return with the value in
> brackets.
> 
> Sascha
Arrgh.. I have myself to blame for inconsistent return styles. Probably we need 
an equivalent of checkpatch and a Lindent for U-Boot v2? I suppose the right 
style is return without brackets?

Regards,
Nishanth Menon

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
U-Boot-Users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Reply via email to