Sascha,

> -----Original Message-----
> From: Sascha Hauer [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, June 03, 2008 3:08 AM
> To: Menon, Nishanth
> Cc: [email protected]; Laurent Desnogues; [EMAIL PROTECTED];
> [EMAIL PROTECTED]; Gopinath, Thara; Kamat, Nishant; Syed Mohammed, Khasim
> Subject: Re: [Patch 05/17] U-Boot-V2:ARM: Introduce capability to 
> havedifferent stack/malloc area
> 
> This patch rises an issue we currently have in U-Boot-v2: We have as
> many stack/memory strategies as we have architectures :(
> 
> Instead of modifying this for one architecture I would prefer something
> like this (currently no implementation, only kconfig).
> Would this solve your issues?
Yes, :). Couple of minor comments though..

> diff --git a/common/Kconfig b/common/Kconfig
> index 79a3684..d764482 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -19,13 +19,66 @@ menu "General Settings              "
>  config BOARDINFO
>       string
> 
> +menu "memory layout                 "
Curious: Why have the extra space? I see this in other places too.. it kind of 
messes up the defconfig with trailing spaces :(.

> +choice
> +     prompt "select stack base policy"
s/stack/heap?
> +     depends on HAVE_CONFIGURABLE_MALLOC
> +
> +config MALLOC_BASE_DEFAULT
> +     bool
> +     prompt "place stack before U-Boot"
s/stack/heap?
> +
> +config MALLOC_BASE_FIXED
> +     bool
> +     prompt "manually assign a malloc base"
> +
> +endchoice
> +
> +endmenu
> +
Ack to the changes. This should be good for me.

Regards,
Nishanth Menon

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
U-Boot-Users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Reply via email to