Remy Bohmer wrote: > Hello Stefano, > > >> Great ! It works, I tested now with bigger files and it sounds good ! >> > > Good news! > > >> I have seen that the complete patch (all patch 0-xx) is not so big and >> smaller as the limit of the mailing list (17k < 40k). What about to send >> only the complete patch ? It is easier to read for the review. >> > > I made it seperate patches because all changes are seperate from each other. > One does not have to install the complete series. Every step should > result in a bootable and working driver. > Some other rule says: Keep patches as small as possible... > > I looked at the complete change at first, but that makes it > unreadable, and I believe, harder to review. > Many changes are trivial, only some are more intrusive... > > >> There are some issues with the coding style, too (trailing blanks, for >> example). >> > > hmm, I have configured quilt such that it normally removes those > whitespaces... > I have to find out what went wrong here. > > I only encountered one whitespace issue, in patch 5 and was able to fix it. I use the --whitespace=strip option in git-am, so trailing whitespace isn't a problem. > Wolfgang, Is the merge window for these patches still open? > If so, I will clean up the patches, and distribute it again in about an hour. > > I've applied your patches to the net repo, and since you submitted them by the deadline it should go in this release.
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
