Hi Jerry, On Thursday 05 June 2008, Jerry Van Baren wrote: > Stefan Roese wrote: > > This patch now adds a new header file (asm-ppc/ppc4xx-sdram.h) for all > > ppc4xx related SDRAM/DDR/DDR2 controller defines. > > > > Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> > > --- > > include/asm-ppc/ppc4xx-sdram.h | 1156 > > ++++++++++++++++++++++++++++++++++++++++ 1 files changed, 1156 > > insertions(+), 0 deletions(-) > > create mode 100644 include/asm-ppc/ppc4xx-sdram.h > > Hi Stefan, > > Not a big deal, but it would probably have been better to switch this > patch [3/8] and the previous patch [2/8] - add the header and then > remove all the code the header replaces - so that it would be git-bisect > safe.
No, I don't think so. Adding the new header without removing the code in the "old" header will break compiling too. So this is not git-bisect safe either. The only safe way would have been to *not* split those two patches at all. But this is not possible because of the 100k size limit of this list. :-( Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] ===================================================================== ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
