Scott Wood wrote: > On Sat, Jun 07, 2008 at 12:29:26PM -0400, Jerry Van Baren wrote: >> diff --git a/common/cmd_fdt.c b/common/cmd_fdt.c >> index ede65ae..8592128 100644 >> --- a/common/cmd_fdt.c >> +++ b/common/cmd_fdt.c >> @@ -403,7 +403,8 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char >> *argv[]) >> } >> #ifdef CONFIG_OF_BOARD_SETUP >> /* Call the board-specific fixup routine */ >> - else if (argv[1][0] == 'b') >> + else if ((argv[1][0] == 'b') && (argv[1][1] == 'o') && >> + (argv[1][2] == 'a')) >> ft_board_setup(fdt, gd->bd); >> #endif > > strncmp() would be clearer... > > -Scott
Yeah, but that is the way the rest of them are. :-/ Hmmm, looking at the other command/cmd_*.c files, it looks like my parsing character-by-character is in the minority vs. strncmp(). Best regards, gvb ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users