Shinya Kuribayashi wrote: >> + andi a1, 0xff /* spread fillword */ >> + LONG_SLL t1, a1, 8 >> + or a1, t1 >> + LONG_SLL t1, a1, 16 >> +#if LONGSIZE == 8 >> + or a1, t1 >> + LONG_SLL t1, a1, 32 >> +#endif >> + or a1, t1 >> +1: >> + >> +FEXPORT(__bzero) >> + sltiu t0, a2, LONGSIZE /* very small region? */ >> + bnez t0, .Lsmall_memset >> + andi t0, a0, LONGMASK /* aligned? */ > > ^ > > [further part snipped] > > Please fix wrong indentations with proper tabs. I know this is exactly > the same as Linux's memset, but we prefer to fix it correctly in U-Boot.
I found that above is an intended space to indicate that the instruction is in the delay slot. I think it's probably a good old convention in MIPS assembly programming, and would like to leave it as it is, IMHO. Anyway, sorry for my ignorance and please ignore my comments on this. -- Shinya Kuribayashi NEC Electronics ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
