In message <[EMAIL PROTECTED]> you wrote:
>
> The port now uses the CFI-driver so board/RRvision/flash.c has been removed.
> Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]>
> ---
> Makefile | 385 +++++++++++++++++++++++++++++++
> board/RRvision/Makefile | 4 +-
> board/RRvision/RRvision.c | 9 +-
> board/RRvision/flash.c | 522
> ------------------------------------------
> common/lcd.c | 9 +-
> cpu/mpc8xx/cpu_init.c | 2 +-
> cpu/mpc8xx/fec.c | 8 +
> cpu/mpc8xx/lcd.c | 185 ++++++++++++++-
> cpu/mpc8xx/video.c | 22 ++-
> include/configs/RRvision.h | 210 +++++++++++++----
> include/configs/TTTech_env.h | 99 ++++++++
> tools/Makefile | 20 ++
> 12 files changed, 891 insertions(+), 584 deletions(-)
> delete mode 100644 board/RRvision/flash.c
> create mode 100644 include/configs/TTTech_env.h
>
> diff --git a/Makefile b/Makefile
> index 8bfc891..538153c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1058,6 +1058,391 @@ RRvision_LCD_config: unconfig
> @echo "#define CONFIG_SHARP_LQ104V7DS01" >>$(obj)include/config.h
> @$(MKCONFIG) -a RRvision ppc mpc8xx RRvision
>
> +RRvision_LCD104V1DG61_config: unconfig
...
> +RRvision_LCD104_config: unconfig
...
> +RRvision_LCD5_config: unconfig
...
> +RRvision_LCD_PM070WL3_BIGMEM_prodtest_config: unconfig
> + @echo "#define CONFIG_PRODTEST" >$(obj)include/config.h
> + @echo "#define CONFIG_LCD" >>$(obj)include/config.h
> + @echo "#define CONFIG_PM070WL3" >>$(obj)include/config.h
> + @echo "#define CONFIG_TTTECH_BIGMEM" >>$(obj)include/config.h
> + @$(MKCONFIG) -a RRvision ppc mpc8xx RRvision
We will not add 380+ lines of Makefile for just a single board. Assume
evey other vendor who has to support several configurations did the
same.
Please simplify this code so you can use a minimum of new lines in the
global Makefile. See other boards how to do this.
> diff --git a/common/lcd.c b/common/lcd.c
> index ebf377a..e54d4f5 100644
> --- a/common/lcd.c
> +++ b/common/lcd.c
> @@ -70,6 +70,13 @@
> # if (CONSOLE_COLOR_WHITE >= BMP_LOGO_OFFSET)
> # error Default Color Map overlaps with Logo Color Map
> # endif
> +
> +# ifndef CONFIG_LCD_LOGO_X
> +# define CONFIG_LCD_LOGO_X 0
> +# endif
> +# ifndef CONFIG_LCD_LOGO_Y
> +# define CONFIG_LCD_LOGO_Y 0
> +# endif
> #endif
>
> DECLARE_GLOBAL_DATA_PTR;
> @@ -768,7 +775,7 @@ static void *lcd_logo (void)
> #endif /* CONFIG_SPLASH_SCREEN */
>
> #ifdef CONFIG_LCD_LOGO
> - bitmap_plot (0, 0);
> + bitmap_plot (CONFIG_LCD_LOGO_X, CONFIG_LCD_LOGO_Y);
> #endif /* CONFIG_LCD_LOGO */
>
> #ifdef CONFIG_MPC823
Please make this a separate patch so the responsible custodian can
pick it up.
> --- a/cpu/mpc8xx/fec.c
> +++ b/cpu/mpc8xx/fec.c
> @@ -837,6 +837,8 @@ static void fec_halt(struct eth_device* dev)
> #define PHY_ID_LSI80225B 0x0016f880 /* LSI 80225/B */
> #define PHY_ID_DM9161 0x0181B880 /* Davicom DM9161 */
> #define PHY_ID_KSM8995M 0x00221450 /* MICREL KS8995MA */
> +#define PHY_ID_DP83846A 0x20005c20 /* NatSem DP83846A */
> +#define PHY_ID_DP83847 0x20005c30 /* NatSem DP83847 */
>
> /* send command to phy using mii, wait for result */
> static uint
> @@ -924,6 +926,12 @@ static int mii_discover_phy(struct eth_device *dev)
> case PHY_ID_KSM8995M:
> printf("MICREL KS8995M\n");
> break;
> + case PHY_ID_DP83846A:
> + printf("NatSem DP83846A\n");
> + break;
> + case PHY_ID_DP83847:
> + printf("NatSem DP83847\n");
Please s/NatSem/NatSemi/ here.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Calm down, it's *__only* ones and zeroes.
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
