In message <[EMAIL PROTECTED]> you wrote: > > I meanwhile realized that the entire makefile system doesn't really cope > with the fact. So what I'm left with is something along the lines of
Please explain what's the problem... > the attached patch, where the cpu/arm920t/start.S #includes a > cpu/arm920t/s3c24x0/start.S file. > > It's not really nice, but otherwise I assure you anyone touching the > arm920t start.S file again will find itself in #ifdef/endif hell, once > all my s3c24xx related patches would be merged... I really dislike the code duplication. > +/* > + * armboot - Startup Code for S3C24xx CPU-cores You're posting this on the wrong mailing list, then. Did you mean [EMAIL PROTECTED] ? ;-) ... > +#ifndef CONFIG_SKIP_RELOCATE_UBOOT > +relocate: /* relocate U-Boot to RAM */ > + adr r0, _start /* r0 <- current position of code */ > + ldr r1, _TEXT_BASE /* test if we run from flash or RAM */ > + cmp r0, r1 /* don't reloc during debug */ > + beq stack_setup > + > + ldr r2, _armboot_start armboot? > + ldr pc, _start_armboot > + > +_start_armboot: .word start_armboot ? > --- u-boot.orig/cpu/arm920t/start.S > +++ u-boot/cpu/arm920t/start.S > @@ -103,6 +103,10 @@ > #endif > > > +#if defined(CONFIG_S3C24xx) > +#include "s3c24x0/start.S" > +#else Why cannot we handle this on a Makefile level? > --- u-boot.orig/include/configs/VCMA9.h > +++ u-boot/include/configs/VCMA9.h > @@ -35,6 +35,7 @@ > */ > #define CONFIG_ARM920T 1 /* This is an ARM920T Core > */ > #define CONFIG_S3C2410 1 /* in a SAMSUNG S3C2410 SoC > */ > +#define CONFIG_S3C24xx 1 /* in a SAMSUNG S3C24xx family > */ Is this really needed? Should not CONFIG_S3C2410 automatically include setting CONFIG_S3C24xx ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] "A complex system that works is invariably found to have evolved from a simple system that worked." - John Gall, _Systemantics_ ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
