Hello Jens, Jens Gehrlein wrote: > Heiko Schocher schrieb: >> Hello Jens, >> >> one comment to your patch: >> >> Jens Gehrlein wrote: >> >>> Signed-off-by: Jens Gehrlein <[EMAIL PROTECTED]> >>> --- >>> >>> Fixed two bugs: >>> a) added NFS mount option "rw" to default environment >>> b) added prefix $(obj) in front of .depend in Makefile. Thank you >>> Magnus for catching that. >>> >> [...] >>> + >>> +/******************************************************************************* >>> >>> + * Environment >>> + >>> ******************************************************************************/ >>> >>> + >>> +#define CONFIG_BOOTDELAY 4 >>> + >>> +/* Default values */ >>> +#define CONFIG_NETMASK 255.255.255.0 >>> +#define CONFIG_IPADDR 172.20.5.100 >>> +#define CONFIG_SERVERIP 172.20.5.121 >>> >> Please delete this block. We do not accept such settings in default >> config files. > > To understand you properly: do you mean the defines for netmask, ipaddr > and serverip, i.e. bootdelay and headerline are okay? I ask, because you > quoted the upper lines, too.
Yes, I only meant netmask, ipaddr and serverip. bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ U-Boot-Users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/u-boot-users
