On Tue, 08 Jul 2008 16:35:00 +0200
Andre Schwarz <[EMAIL PROTECTED]> wrote:
> Kim,
>
> I forgot to mention that both fpga.c are _not_ the same.
> They are using different FPGA sizes _and_ different I/Os on different cpu.
the size is a one-line thing that can be easily and understandably
#ifdeffed. The gpio struct difference can be fixed like this:
static u32 get_dvo()
{
#ifdef CONFIG_MPC83XX
volatile immap_t *im = (volatile immap_t *)CFG_IMMR;
volatile gpio83xx_t *gpio = (volatile gpio83xx_t *)&im->gpio[0];
return gpio->dat;
#else
#ifdef CONFIG_MPC5XXX
struct mpc5xxx_gpio *gpio = (struct mpc5xxx_gpio*)MPC5XXX_GPIO;
return gpio->simple_dvo;
#endif
#endif
}
...and subsequently use get_dvo() later in the file.
> It's not possible for me to use a common file for the short term.
> Maybe later when the FPGA interface got mature ...
I really think code maintenance will suffer if you don't do it now;
afaict, the file is functionally equal modulo the size one-liner.
Kim
-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
