In message <[EMAIL PROTECTED]> you wrote:
> -Suport for the Xilinx ML507 Development Board
There are some coding stylke issues: trailing white space, aliglnment
not by TAB, etc.
> +++ b/board/xilinx/ml507/init.S
> @@ -0,0 +1,45 @@
> +/*
> + (C) Copyright 2008
> + Ricado Ribalda, Universidad Autonoma de Madrid,
> ricardo.ribalda<at>uam.es , ricardo.ribalda<at>gmail.com
Line too long.
> +int checkboard(void)
> +{
> +
> + printf
> + ("ML507 Board ported by Ricardo Ribalda [EMAIL PROTECTED]
> (http://qtec.com) \n");
Line too long. And please print only SHORT messages!
> +phys_size_t initdram(int board_type)
> +{
> + return 256 * 1024 * 1024;
Please use memsize() to autodetect the size of your RAM instead of
hard-wiring it.
> +int testdram(void)
> +{
> + printf("test: xxx MB - ok\n");
> +
> + return (0);
> +}
Please remove.
> new file mode 100644
> index 0000000..054661c
> --- /dev/null
> +++ b/board/xilinx/ml507/u-boot.lds
> @@ -0,0 +1,149 @@
> +/*
> + * (C) Copyright 2000
> + * Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED]
> + * Modified by: Ricardo Ribalda Delgado ricardo.ribalda<at>gmail.com
> ricardo.ribalda<at>uam.es
Line too long.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
It became apparent that one reason why the Ice Giants were known as
the Ice Giants was because they were, well, giants. The other was
that they were made of ice. -Terry Pratchett, _Sourcery_
-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
U-Boot-Users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/u-boot-users
